feat: enforce markdown formatting on save #6969
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
github-actions
bot
added
the
documentation
dmadisetti
changed the title
dmadisetti
force-pushed
the
dm/md-check
branch
from
4f72213 to
aeb107f
Compare
for more information, see https://pre-commit.ci
| @@ -0,0 +1,48 @@ | |||
| # MF007: markdown-dedent | |||
There was a problem hiding this comment.
i wonder if the rule should be markdown-indentation since it captures more than dedent. but if this is internal, we can change the name whenever
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
This PR is being reviewed by Cursor Bugbot
Details
You are on the Bugbot Free tier. On this plan, Bugbot will review limited PRs each billing cycle.
To receive Bugbot reviews on all of your PRs, visit the Cursor dashboard to activate Pro and start your 14-day free trial.
| return { | ||
| code: `${start}${escapedCode}"""\n)`, | ||
| offset: start.length, | ||
| }; |
There was a problem hiding this comment.
Bug: Markdown Parsing Error Causes Invalid Python Syntax
The markdown parser generates an extra double-quote character when breaking long single-line markdown cells. This creates invalid Python syntax by mixing string literal types, such as mo.md(" with r""".
|
|
||
| if not notebook_cell: | ||
| return | ||
|
|
There was a problem hiding this comment.
Bug: Linting Halts on Unmatched Cells
The check function exits prematurely when a notebook cell cannot be matched, preventing the linting rule from processing subsequent cells. This leads to incomplete linting for the entire notebook.
Fixes #6458
📝 Summary
Adds lint rule and codegen change that enforces markdown dedent.
Following front end convention, the following markdown is expected:
note: This is a noisy PR since examples are formatted. Look at commits standalone:
test: Add in tests for md check
feat: Add markdown tidy rule and auto formatting
tidy: refresh examples
docs: update documentation rules