Skip to content

Conversation

@smorey2
Copy link

@smorey2 smorey2 commented Oct 4, 2017

Reference: #177

Copy link
Collaborator

@stomita stomita left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The snapshot files include truly generated uuids, which prevents matching previous result.

To generate snapshots with fake uuids, run
npm run test:storyshots -- -u

@smorey2
Copy link
Author

smorey2 commented Dec 5, 2017

I merged to upstream, and noticed the commit from

"Switched to using prop-types" removed all return types in storyshots. func -> other, bool -> other.

not sure why prop-types was introduced, and allowed to break stories

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants