Skip to content

Probando Tests #14

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
alejandroklever wants to merge 157 commits into
base: master
Choose a base branch
from
Open

Probando Tests #14

alejandroklever wants to merge 157 commits into from

Conversation

@alejandroklever
Copy link

@alejandroklever alejandroklever commented Mar 2, 2021

Aquí... casual... esperando a que explote

Alejandro Klever Clemente added 30 commits March 15, 2020 20:51
Gramatica lalr(1) de Cool definida (Pendiente a cambios)
52a1d41
iniciando AST
014a1a0
Serializador de parser terminado. Pediente a definir la prioridad de …
7d97cee 
…los operadores de lenguaje cool
parsea el primer programa de cool : Implementar Scope y Semantic Checker
1bc4ccf
testing new lexer
d505eea
new lexer finished
9165a40
merge with new_lexer branch
b2c8ac4
preparing cmp module for erro detection
51b6139
preparing cmp module for erro detection
b492162
regular save
ac53b36
Fixed up the grammar for operators "=", "<", "<=". Improved Parser Se…
4eae974 
…rializer (Need a better inpection analysis)
Lexical error detection functional; Improved parser generation proces…
8622d94 
…s; Better serialization of lexer and parser; Improved grammar API;
merge with branch error_detections
a9bdd3d
First stage of Recovery Mode working good
5fc945c
Implemented class TypeCollector
caa1e4e
Implemented class TypeCollector
d2145cc
Type Builder finished
6f29f23
Added examples in tests folder
4c3221b
Added examples in tests folder
ccdcc7b
Added examples in tests folder
c606570
added new error productions to the grammar
5ca901f
Created Cool Base Class Hierarchy
61e29e7
Added AUTO_TYPE and SELF_TYPE to cool base class hierarchy
746db0d
Changed types of the parameters attribues and methods in class Ty…
494d8bb 
…pe for a Dict[str, Attribute] and a Dict[str, Method] instead of list, respectively
save
f618955
Fixed up decorator for productions, terminals and errors
04963be
Added basic COOL Types
7a69abf
Type chequer review
57369a1
Setting "Object" as default parent solved in type building time
760a365
SelfTypeReplacement in process
c1ac4cf
alejandroklever
alejandroklever commented Jul 28, 2021
View reviewed changes
Copy link
Author

@alejandroklever alejandroklever left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

AlejandroKlever and others added 24 commits August 6, 2021 23:39
-
736ee31
Added a constructor
a19c142
created a constructor creator
fe949e3
Generating cil
aeebee6
Added inference type feature
3bc2de0
A mitad de camino
24db105
Switch dando problemas
01b03a4
Switch case cil Algorithm finished
4c43a8e
Visitor Cool to Cil finished. A revision of the labels and comments i…
67212c0 
…s needed, specially on the switch case node.
Improved labels of the switch case transformation to cil
14b2a2b
-
692543e
Starting to create the structure for the MIPS AST
6c7c0db
Starting to create the structure for the MIPS AST
81badc7
Fixed an error in the dynamic call translation to cil. Completed the …
bfb2e46 
…translation to cil of all the default types and their methods.
Added an empty instruction to the mips ast nodes
143c79e
Added instruction jr $ra at the end of each function label in the m…
f9a0714 
…ips file
Fixed an error in the naming of the mips and cil file names
073d3e9
Translation of arithmetic operations to mips already done
31c04a2
Cil to Mips translation terminated, its time to fin bugs.
5841feb
Redefined type Int, Bool and String. Fixing errors in switch case tra…
2b64b1c 
…nslation
@LauTB
updated readme and upload report
5846e9d
Need to redefine instances
228f1ea
Tests passed. Refactoring process
04f803f
Merge branch 'feature/code-generation-process'
c61e395
@apiad
Copy link
Member

apiad commented Mar 8, 2022 •
edited
Loading

Evaluación

  • Alejandro Klever Clemente C-411
  • Laura Tamayo Blanco C-411
  • Miguel Angel Gonzalez Calles C-411

Requisitos mínimos (3)

  • El proyecto pasa todos los tests
  • El informe existe y explica el uso del compilador y la arquitectura básica

Requisitos intermedios (4)

  • Se implementaron las fases de chequeo semántico de forma separada y utilizando patrones adecuados
  • La arquitectura del compilador está organizada de forma coherente y mantenible

Requisitos extra (5)

  • Se implementaron las fases de generación de código intermedio y código objeto con patrones adecuados
  • Se resolvieron los problemas de representación de objetos en memoria e invocación de métodos virtuales de forma eficiente
  • Se resolvieron los problemas de boxing/unboxing de forma eficiente

Comentarios

  • La implementación de la inferencia de tipos para AUTO_TYPE está muy bien 👍
  • La generación de código está muy poco explicada por lo que no podemos evaluar cómo resolvieron los problemas de runtime, aunque en el código veo que tienen un AST de MIPS y un visitor de COOL a MIPS. No tienen 5 todavía solamente porque la generación de código está muy pobremente explicada, pero creo que toda la funcionalidad la tienen ahí.

Nota final

Evaluación Nota
Final 4

@apiad apiad self-requested a review March 8, 2022 02:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@apiad apiad Awaiting requested review from apiad

Assignees

No one assigned

Labels

Aprobado Final Finalizado

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@alejandroklever @apiad @jpconsuegra @LauTB