Skip to content

some minor improvements #35

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
isacikgoz merged 1 commit into from
Nov 19, 2024
Merged

some minor improvements #35

isacikgoz merged 1 commit into from
Nov 19, 2024

Conversation

@isacikgoz
Copy link
Member

@isacikgoz isacikgoz commented Nov 19, 2024

Summary

  • Bump mysql and postgres versions to reflect min versions we use.
  • Return non-zero code after an error
  • Remove unused function for interface check
  • Add some documentation

@isacikgoz isacikgoz added the 2: Dev Review Requires review by a core committer label Nov 19, 2024
@isacikgoz isacikgoz requested a review from agnivade November 19, 2024 12:32
@isacikgoz isacikgoz merged commit b3c00f7 into master Nov 19, 2024
2 checks passed
@isacikgoz isacikgoz deleted the minor-improvements branch November 19, 2024 15:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@agnivade agnivade agnivade approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

2: Dev Review Requires review by a core committer

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@isacikgoz @agnivade