Adding campaign republish behavior docs #561
Conversation
adiati98
left a comment
adiati98
left a comment
There was a problem hiding this comment.
Thanks for the PR, @escopecz!
As there are a few Vale error warnings, I just want to make sure a couple of things here:
- Is there any "unpublish" word across the changes refers to Mautic's term? If so, Vale wants it to be "Unpublish". If there's none, we can ignore this by wrapping the sentence within
.. vale offand.. vale onstatements. - Should the word "cron" in line 128 capitalized ("Cron)? If not, we can also ignore it.
TIA! ✨
|
|
||
| .. vale on | ||
| When you Unpublish and then republish a Campaign, Mautic provides control over how scheduled events with relative delays - such as "Send Email 5 days after joining" - should behave. This feature gives you flexibility in managing Campaign timing based on your specific use case. |
There was a problem hiding this comment.
This functionality is now called 'activate' and 'deactivate' so it's going to need updating throughout this PR.
| Publish and Unpublish Campaigns | ||
| ====================================== | ||
|
|
||
| When you publish or Unpublish a Campaign, Mautic displays a confirmation message that shows the current republish behavior setting. This helps you understand what happens to scheduled events before you confirm the action. |
There was a problem hiding this comment.
Oh man. The wording is not consistent in the UI. Here are the screenshots but I think we'll have to update the wording in the product too, right?
There was a problem hiding this comment.
Yes, we will indeed. cc @andersonjeccel for visibility.
There was a problem hiding this comment.
What would be the re-wording for republish? Reactivate?
There was a problem hiding this comment.
I believe it should now be:
Active / Activate / Reactivate
Inactive / Deactivate
Referencing this PR: mautic/mautic#14239 and this PR: mautic/mautic#13500
There was a problem hiding this comment.
So the new setting label should be called "Campaign Reactivate Behaviour"?
| * **Use date range for all views** - When viewing a Campaign, the date range of actions, conditions, decisions, and Contacts displayed in the tabs, Mautic uses this date range by default. | ||
|
|
||
| * **Use summary statistics** - Improves performance when viewing a Campaign with thousands of events per day by using summarized data. When you first turn on this setting you need to run a :ref:`cron job<campaign cron jobs>` to summarize existing data. | ||
| * **Use summary statistics** - Improves performance when viewing a Campaign with thousands of events per day by using summarized data. When you first turn on this setting you need to run a :ref:`Cron job<campaign cron jobs>` to summarize existing data. |
There was a problem hiding this comment.
Let's link to the specific cron job here.
adiati98
left a comment
adiati98
left a comment
There was a problem hiding this comment.
Hi @escopecz,
I see that your branch is way behind our current 5.2 branch, by 211 commits. Can you please update your branch (with whichever method you think best!) with the latest state of the docs?
We also have branch '7.0` for Mautic 7. Would it be better to pull the changes from this branch?
TIA!
|
@adiati98 I created the branch 7.1 from the 7.0 branch and that's the target branch for this PR. As this won't go to Mautic 7.0 but 7.1. Is that alright? |
That's totally fine and actually great! What I meant is your PR branch here based on below screenshot. The build is failing in this PR because of some broken links. I've fixed these exact links a couple of months ago. That's why I tracked your branch and noticed that the base branch that you're using to work on the changes is outdated. 
|
|
@adiati98 gotcha. I don't push to the base branches in my fork but I keep it up to date on my local. So would it mean that your fixes weren't merged to the 7.0 branch? |
escopecz
force-pushed
the
campaign-republish
branch
from
7fb7d7a to
bf4fb31
Compare
escopecz
requested review from
adiati98 and
favour-chibueze
and removed request for
a team
|
@adiati98 you were right. I based the 7.1 branch on an outdated 7.0 branch. I rebased the 7.1 to the latest 7.0 branch and this PR on top of that 7.1 branch. Although I still can see some failures in files I didn't change. @RCheesley I pushed the rewording changes. Is it good like this? |
|
@escopecz thanks so much for updating the branch! ✨ @RCheesley New broken links come from https://developer.mautic.org/. Does this have anything to do with the developer docs redirect from the outdated to the new one? I'll add them to the links ignore list some time this week or fix them so they're pointing to the correct link in the new docs if available. 👍🏼 |
3 participants
Docs for mautic/mautic#15634