-
Notifications
You must be signed in to change notification settings - Fork 63
update campaign builder images #562
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: 7.0
Are you sure you want to change the base?
Conversation
Backmerge 5.2 into 6.0
Revert "Backmerge 5.2 into 6.0"
Co-authored-by: Ruth Cheesley <[email protected]>
Add issue and PR templates
Fix broken links in branch 5.2
Fix invisible text in sidebar version dropdown options [5.2]
…opdown-5.2 Revert "Fix invisible text in sidebar version dropdown options [5.2]"
Fix invisible text in sidebar version dropdown options [5.2]
docs: add adi-ray as a contributor for doc
Fix for : Update images in docs/plugins/amazon.rst in branch 5.2 #365
Fix for : Update images in docs/plugins/vtiger.rst in branch 5.2 #385
Fix for: Update images in docs/plugins/twilio.rst in branch 5.2 #384
docs: add ashwini2k6 as a contributor for doc
docs: add Lokesh9106 as a contributor for doc
adiati98
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for your PR, @fakela! ✨
This looks great so far. But I have a few things for you to address here:
-
Looking at the UI images, these aren't from Mautic 5. I believe these are Mautic 7?
Can you please rebase this PR and point it to the right base branch? Currently, your PR is pointing to
5.2. You can close and create a new PR if it's easier for you. 🙂 -
As we want to maintain consistency, please rename the files using underscore. For example:
campaign_events.png. That said, you also need to fix the name within the RST file: https://github.com/mautic/user-documentation/blob/5.2/docs/campaigns/campaign_builder.rst -
Please edit your PR description. As the changes here are for branch 7, it should only close issue #468. Other issues are for branch 5.2 and 6.0.
Please let me know if you have questions or need help. Thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you please retake the screenshot to include the copy icon button on hover state, like the existing?
Description
Updated screenshots for the campaign builder documentation to match the current Mautic UI.
Linked issue
Closes #468
Screenshots or screen recordings