Remove deprecated text-encoder #72
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A compliant implementation of TextDecoder has been a Node.js global since v11 (so all maintained versions of Node have it).
|
@mbostock would it be possible to accepts this PR? It would be much appreciated! If you do not have the time for this, I might be able to help if you give me access to this repo. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes the
text-encodingdependency, which is no longer maintained. The change is minimal.A compliant implementation of TextDecoder has been a Node.js global since v11 (so all maintained versions of Node have it and this package is redundant for the default build configuration).
Closes #51