feat(SF2.0/UpcomingDepartures): Show scheduled trips for bus and CR #2850
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We will do this correctly later, so no need to maintain a special function for it now
thecristen
approved these changes
Dec 23, 2025
Collaborator
thecristen
left a comment
thecristen
left a comment
There was a problem hiding this comment.
One small thing to add now or later, otherwise nice!
| defp realtime_display(assigns) do | ||
| ~H""" | ||
| <span class="font-bold"> | ||
| <.icon type="icon-svg" name="icon-realtime-tracking" /> |
Collaborator
There was a problem hiding this comment.
let's add an aria-label here!
Contributor
Author
There was a problem hiding this comment.
Good call!
I'll treat that as a follow-up, since I'm not actually sure what aria-label to use (and because this isn't new - this code was moved, not added 🙂)
joshlarson
deleted the
jdl/sf2.0/ud/bus-interleave-schedule-and-prediction-data
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Features:
Upcoming Departureentries for bus and CR trips that are scheduled but don't have predictions.Asana Ticket: [SF/UD] Bus: Include predictions and scheduled-not-cancelled trips