fix(SF2.0/UpcomingDepartures): Get scheduled and predicted other_stops #2854
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joshlarson
force-pushed
the
jdl/sf2.0/ud/cr-fancy-labels
branch
from
a55dfbf to
8b0489a
Compare
joshlarson
force-pushed
the
jdl/sf2.0/ud/refactor-predictions-schedules-fetching
branch
from
3703a0d to
247158b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes an issue present in Ye Olde Schedulle Finderre, as well as previous instances of this, where commuter rail trips would only be endowed with predictions for their first stop until they actually pulled out of the station, like 👇.
Now, instead of checking only schedules or only predictions, we check
predicted_scheduleswhich already has the schedules and predictions stitched together, in order to fallback to schedules when predictions are unavailable, even within a single trip:(Left: SF1.0 without the fix; Right: SF2.0 with the fix)
Asana Ticket: [SF/UD] CR: Use schedule data to fill in trip details when predictions are for a partial trip