Skip to content

Fix file drag-and-drop inconsistency in Firefox - Fixes #45 #353

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Fix file drag-and-drop inconsistency in Firefox - Fixes #45 #353

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 7 additions & 12 deletions drag-and-drop/File-drag.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@
<body>
<h1>Drag and drop files</h1>

<div id="drop_zone" ondrop="dropHandler(event);" ondragover="dragOverHandler(event);">
<div id="drop_zone" ondrop="dropHandler(event);" ondragover="dragOverHandler(event);" ondragleave="dragLeaveHandler(event);">
<p>Drag one or more files to this Drop Zone ...</p>
</div>

Expand All @@ -33,6 +33,12 @@ <h1>Drag and drop files</h1>

// Prevent default behavior (Prevent file from being opened)
ev.preventDefault();
// Set dropEffect to indicate this is a copy operation
ev.dataTransfer.dropEffect = 'copy';
}

function dragLeaveHandler(ev) {
console.log('File(s) left drop zone');
}

function dropHandler(ev) {
Expand All @@ -57,17 +63,6 @@ <h1>Drag and drop files</h1>
}
}

// Pass event to removeDragData for cleanup
removeDragData(ev)
}

function removeDragData(ev) {
console.log('Removing drag data')

if (ev.dataTransfer.items) {
// Use DataTransferItemList interface to remove the drag data
ev.dataTransfer.items.clear();
}
}
</script>
</body>
Expand Down