Expand graph in path.subgraph_all when filterStartNode == false
#613
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.



Description
When
filterStartNode == false,path.subgraph_allwould always return the start node. However, it would not expand beyond it if it didn't meet the criteria inlabelFilter. This is confusing asfilterStartNode == falsesuggests that it will always be ignored. With this PR, it'll always expand beyond the start node.In addition, using negative values for
maxHopswill now be ignored and use the defaultstd::numeric_limits<int64_t>::max()instead.Pull request type
Related issues
This is related to #610 . To fix the issue, the documentation should be updated to highlight differences between DFS for
path.expand/path.createand BFS forpath.subgraph_all/path.subgraph_nodes.######################################
Reviewer checklist (the reviewer checks this part)
Module/Algorithm
Documentation checklist