Resolved the cppcheck style warnings #172
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cppcheck is a popular tool that performs static code analysis outputting warnings if constructs are error-prone or do not make sense. Currently nanosvg produces many warnings, though, making spotting real errors in a project harder than necessary. This commit resolves the following warings: nanosvg.h:829: style: Variable 'data' is reassigned a value before the old one has been used. nanosvg.h:2907: style: Variable 'fp' is reassigned a value before the old one has been used. The cause of these warnings is that both variables are set to NULL and then assigned a different value to - which is no bug but adds an unnecessary assignment to the code.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cppcheck is a popular tool that performs static code analysis outputting warnings if constructs are error-prone or do not make sense. In the project wxMaxima some of these warnings have proven to be extremely useful . Getting rid of any warnings that can be fixed makes things easier for users who want cppcheck to find bugs in their code.
This commit resolves the following warnings:
The cause of these warnings is that both variables are set to NULL and then assigned a different value to - which is no bug but adds an unnecessary assignment to the code.