odxlink: make ODX references work if they point to proxy objects #451
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
... and weak references ought to be used. The problem is that `weakref.proxy(x)` raises an exception if `x` already is a proxy object. This can happen if, e.g., a diag comm is referenced via an ODXLINK ref which in turn gets referenced by a short-name reference. Signed-off-by: Andreas Lauser <[email protected]> Approved-by: Michael Hahn <[email protected]>
kayoub5
reviewed
Oct 24, 2025
Signed-off-by: Andreas Lauser <[email protected]> Requested-by: [at]kayoub5
kayoub5
approved these changes
Oct 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is only relevant if weak references ought to be used: The problem is that
weakref.proxy(x)raises an exception ifxalready is a proxy object. This can happen if, e.g., a diag comm is referenced via ODXLINK which in turn gets referenced by a short-name reference.Andreas Lauser <[email protected]>, on behalf of MBition GmbH.
Provider Information