Skip to content

Add weak custom CLI hook to extend CommonCLI without forking core commands #1534

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
piotrmalek wants to merge 2 commits into
base: dev
Choose a base branch
from
Open

Add weak custom CLI hook to extend CommonCLI without forking core commands #1534

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d7eef14
Add weak custom CLI hook
piotrmalek Jan 30, 2026
6012757
Polish comment removed
piotrmalek Jan 30, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions src/helpers/CommonCLI.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,11 @@
#include "AdvertDataHelpers.h"
#include <RTClib.h>

extern "C" bool __attribute__((weak))
meshcore_custom_cli(uint32_t sender_ts, const char* cmd, char* reply) {
return false;
}

// Believe it or not, this std C function is busted on some platforms!
static uint32_t _atoi(const char* sp) {
uint32_t n = 0;
Expand Down Expand Up @@ -194,6 +199,7 @@ uint8_t CommonCLI::buildAdvertData(uint8_t node_type, uint8_t* app_data) {
}

void CommonCLI::handleCommand(uint32_t sender_timestamp, const char* command, char* reply) {
if (meshcore_custom_cli(sender_timestamp, command, reply)) return;
if (memcmp(command, "reboot", 6) == 0) {
_board->reboot(); // doesn't return
} else if (memcmp(command, "clkreboot", 9) == 0) {
Expand Down