Echo on success

[andrewdavidmackenzie]

Summary
Currently a mesh packet attempting to be sent is echoed back to the client via the Packet Router, before attempting to send. So, if sending fails, it will appear to the router as if it worked when in fact it failed.

This change only echos back via the router if the sending was successful

Related Issues

Proposed Changes

• Move the section of code that echos back the packet via router to after the call to send (DONE)

Checklist

• Tests pass locally
• Documentation updated if needed

[andrewdavidmackenzie]

For discussion:
The send_mesh_packet method currently returns an error if the call to packet_router.handle_mesh_packet returns an error, even if the packet was successfully sent.

I would consider silencing the error returned by packet_router.handle_mesh_packet using

let _ = packet_router.handle_mesh_packet(mesh_packet);

and letting the client code (in PacketRouter) handling its own errors.