Use toplevel Cargo.toml for feature resolution #15158
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Oct 22, 2025
bonzini
added
module:rust
bonzini
force-pushed
the
cargo-object
branch
9 times, most recently
from
f3af508 to
834dd17
Compare
bonzini
force-pushed
the
cargo-object
branch
6 times, most recently
from
b724c84 to
cd0097f
Compare
bonzini
force-pushed
the
cargo-object
branch
7 times, most recently
from
e2a1d59 to
33c8c6c
Compare
bonzini
force-pushed
the
cargo-object
branch
3 times, most recently
from
41f55fe to
2a8dfca
Compare
bonzini
force-pushed
the
cargo-object
branch
3 times, most recently
from
ee40006 to
8ac0906
Compare
Signed-off-by: Paolo Bonzini <[email protected]>
rust.workspace() is the entry point for global feature resolution. It loads a Cargo.toml file and ensures that all dependencies will be built with the correct set of features. Fixes: mesonbuild#13404
Add features property to cargo.Interpreter to make default features configurable; customization of which features are enabled by default is triggered by rust.workspace(). Fixes: mesonbuild#14290
Signed-off-by: Paolo Bonzini <[email protected]>
Signed-off-by: Paolo Bonzini <[email protected]>
Signed-off-by: Paolo Bonzini <[email protected]>
This is up to 2x faster because it avoids checks for pkg-config and cmake. Signed-off-by: Paolo Bonzini <[email protected]>
Signed-off-by: Paolo Bonzini <[email protected]>
Signed-off-by: Paolo Bonzini <[email protected]>
Some projects may want to override Meson's AST generation for Cargo projects. This was not really doable before without hard coding the results of feature resolution; however, now it will be possible by accessing the results of the global feature resolution from the Rust module's workspace object. At the same time, the subproject must keep using the Cargo method, which is forced by the workspace object's subproject() method, because otherwise the interpreter is not propagated. So just skip the interpretation phase if a Meson.build is present. Signed-off-by: Paolo Bonzini <[email protected]>
bonzini
force-pushed
the
cargo-object
branch
from
92cef88 to
b5e002c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This introduces a skeletal implementation of #14639, which however is already relatable to what is implemented by the cmake module. In particular, workspace().subproject() works, and allows retrieving the overridden dependency as well as the Cargo features of the crate.
Current WIP full version: https://github.com/bonzini/meson/commits/cargo-object-full
Fixes: #13404
Fixes: #14290