Fix lint #213
Closed
Fix lint #213
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
meta-cla
bot
added
the
CLA Signed
There was a problem hiding this comment.
Pull request overview
This PR applies stricter OSS lint formatting rules to improve code consistency. The changes are purely cosmetic and do not affect functionality, focusing on import statement formatting and expression wrapping for better readability.
Key Changes
- Removed blank lines between related import statements in test artifact files
- Added parentheses around ternary expressions in generator contexts for improved clarity
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| tritonparse/reproducer/tests/artifacts/triton_preprocess.py | Removed blank line between related triton import statements |
| tritonparse/reproducer/tests/artifacts/triton_fused_kernel.py | Removed blank line between related triton import statements |
| tritonparse/reproducer/multi_file_analyzer.py | Wrapped ternary expression in parentheses within any() call for better readability |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
This pull request has been merged in 3d3fdaa. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: The oss lint has more strict checks. This diff fixes the format issues.
Differential Revision: D88326557