Support more LRC timestamps #2566
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
phw
approved these changes
Dec 29, 2024
phw
requested changes
Dec 29, 2024
auto-merge was automatically disabled
December 29, 2024 11:10
Head branch was pushed to by a user without write access
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Problem
When saving an ID3 file with LRC synced lyrics, it only accepted a very narrow definition of timestamps (two-digit minutes, two-digit seconds, and three-digit milliseconds). While this is fine for preserving the field (as in PICARD-1092), some plugins may import or download LRCs with different timestamps, and people can edit the field manually and change as well.
No JIRA ticket was open for this problem, and there was no LRC support at all in the previous release.
Solution
I changed the regular expressions that are used for LRC decoding (
ID3File.__lrc_*_re_parse), and the corresponding timestamp parsing atID3File._parse_lrc_text. I also added new test cases for the new timestamps.Action
Additional actions required: