This repository was archived by the owner on Oct 7, 2021. It is now read-only.
Dynamic Settings.ui creation. Simpler AddChain method for non planar chains, Joint based spline deformation opperator #88
+426
−10
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rve that follow the input closer
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This has changes in code that I've made to get over a bug whereby the settings.py file for a component wouldn't be converted to a pyc file when imported by the component. I don't think it's happy with the relative import so the puthon module[settingsUI] namespace it used from the last imported file. This dynamic what of loading the .ui files has always worked well for me, not cost anything as far as I can see.
I've added a simpler addChainNonPlanar method so that the work of clearing the joint orients is done by makeIdentity after the joint has be placed in the normal mgear manor. As it's the guides design to lock joints into a plane, or let the user unlock them if desired, I don't see why the already existing method it so strict and it also can ause flipping issues as discussed on the forum to do with the leg_3jnt component flipping.
I've also added methods to enable my the create a FK Spine based on guide locations.
I've kept the new components that use these out of this pull request. I'll upload a sep repro for these components