Skip to content

package-directory-mismatch: ignore main_test package name #1545

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Oct 15, 2025
Merged

package-directory-mismatch: ignore main_test package name #1545

merged 3 commits into from
Oct 15, 2025

Conversation

@uloamaka
Copy link
Contributor

@uloamaka uloamaka commented Oct 13, 2025 •
edited by alexandear
Loading

This PR updates the package-directory-mismatch rule by unconditionally ignoring the main_test package name for tests.

Closes #1532

@uloamaka uloamaka changed the title fix: package-directory-mismatch - allow main_test package in main.go … fix: package-directory-mismatch - allow main_test package in main.go Oct 13, 2025
@alexandear alexandear changed the title fix: package-directory-mismatch - allow main_test package in main.go package-directory-mismatch: allow main_test package name Oct 14, 2025
@alexandear alexandear changed the title package-directory-mismatch: allow main_test package name package-directory-mismatch: ignore main_test package name Oct 14, 2025
@alexandear alexandear requested a review from chavacava October 14, 2025 12:05
@uloamaka
Copy link
Contributor Author

@alexandear thanks for the review and update.

@chavacava chavacava merged commit d32d4a0 into mgechev:master Oct 15, 2025
10 checks passed
@chavacava
Copy link
Collaborator

Thanks for the PR @uloamaka !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@alexandear alexandear alexandear approved these changes

@chavacava chavacava Awaiting requested review from chavacava

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

package-directory-mismatch: false positive for main_test

3 participants

@uloamaka @chavacava @alexandear