useless-fallthrough: do not report fallthrough before default #1549
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR improves the
useless-fallthroughrule to allow an emptyfallthroughbefore adefaultcase in switch statements, especially for enum-like constants.Background:
revivecurrently requires adefaultcase in switches.default:case is often necessary even when all constants are handled.defaultwith acasethat only containsfallthroughis invalid.To Reproduce
Expected behavior
fallthroughbefore thedefaultcase should not be reported as useless.defaultcase gracefully without requiring comments or lowering confidence scores.Checklist
Footer
Closes #1538