Move TeamsAttachmentDownloader to Core #492
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR relocates the TeamsAttachmentDownloader class from the Teams Extensions library to the Core Builder library, improving code organization and reusability. The original implementation has been replaced with obsolete wrapper classes that delegate to the new location.
Key Changes:
- Moved
TeamsAttachmentDownloaderandTeamsAttachmentDownloaderOptionstoMicrosoft.Agents.Builder.App - Added obsolete wrappers in the original Teams Extensions location for backward compatibility
- Enhanced constructor parameter ordering and added default parameter handling for better usability
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
Microsoft.Agents.Extensions.Teams/App/TeamsAttachmentDownloader.cs |
Replaced implementation with obsolete wrapper classes that inherit from the new Core location |
Microsoft.Agents.Builder/App/TeamsAttachmentDownloader.cs |
New home for the TeamsAttachmentDownloader implementation with updated constructor signature |
Microsoft.Agents.Authentication/ConfigurationConnections.cs |
Added null/empty check for connection name parameter to prevent lookup failures |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
src/libraries/Extensions/Microsoft.Agents.Extensions.Teams/App/TeamsAttachmentDownloader.cs
Show resolved
Hide resolved
…t proper per-request provider
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #504
Fixes #396
This also improves getting
IAccessTokenProviderbased on the current request (IConnections.GetTokenProvider).