Skip to content

Conversation

@tracyboehrer
Copy link
Member

Fixes #307

@github-actions github-actions bot added ML: Samples Tags changes to samples ML: Core Tags changes to core libraries ML: Tests Tags changes to tests labels Nov 12, 2025
@tracyboehrer tracyboehrer marked this pull request as ready for review November 18, 2025 14:49
@tracyboehrer tracyboehrer requested a review from a team as a code owner November 18, 2025 14:49
Copilot AI review requested due to automatic review settings November 18, 2025 14:49
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This pull request improves the AdaptiveCards search and execute functionality by enhancing error handling, refactoring validation logic, and expanding test coverage.

  • Refactored validation logic into reusable methods (TryValidateSearchInvokeValue and TryValidateActionInvokeValue)
  • Improved error handling for malformed or incomplete invoke actions and search requests
  • Added comprehensive test coverage for error scenarios including null actions, unexpected action types, missing search fields

Reviewed Changes

Copilot reviewed 4 out of 5 changed files in this pull request and generated 6 comments.

Show a summary per file
File Description
AdaptiveCardsTests.cs Renamed tests for clarity, added new test cases for error scenarios (null actions, unexpected action types, missing search value/kind/queryText)
AdaptiveCardSearchInvokeValue.cs New file extracting the inner class to a top-level class for better organization
AdaptiveCardInvokeResponseFactory.cs Added SearchResponse factory method and two validation methods for search and action invoke values with proper error handling
AdaptiveCard.cs Refactored route handlers to use new validation methods, improved error response handling, simplified null checks
CopilotStudioAgentConnector.zip Binary file update (sample connector)

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 4 out of 5 changed files in this pull request and generated 8 comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ML: Core Tags changes to core libraries ML: Samples Tags changes to samples ML: Tests Tags changes to tests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

AdaptiveCards does not provide full Search and Action error response handling

2 participants