Skip to content

Conversation

@achamayou
Copy link
Member

Two changes from #7417:

  1. Merge CI checks in, to cut down what otherwise adds ~5 minutes of startup latency to most CI runs
  2. Rename jobs to A and B, they are packed for latency, not necessarily by theme. The contents are still in comment.

@achamayou achamayou requested a review from a team as a code owner November 4, 2025 14:09
Copilot AI review requested due to automatic review settings November 4, 2025 14:09
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR consolidates CI workflows by removing a separate pre-check job and integrating its functionality into the main build jobs. The changes streamline the CI pipeline by consolidating dependency installation and removing serial job dependencies.

  • Removed the separate checks job and integrated CI checks into the first virtual build job
  • Moved package installations (tar, npm, build-essential) from the workflow to the setup-dev.sh script
  • Removed needs: checks dependencies from SNP jobs to enable parallel execution

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
scripts/setup-dev.sh Added tar, npm, and build-essential packages; removed vim from installation list
.github/workflows/ci.yml Removed separate checks job, integrated checks into vmss-virtual-a job, removed job dependencies to enable parallelization

@achamayou achamayou merged commit e844c95 into main Nov 4, 2025
17 checks passed
@achamayou achamayou deleted the merge_ci_checks branch November 4, 2025 20:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants