This repository was archived by the owner on Nov 16, 2023. It is now read-only.
Use environment markers instead of modifying _install_requires#238
Open
ianlini wants to merge 3 commits intomicrosoft:masterfrom
Open
Use environment markers instead of modifying _install_requires#238ianlini wants to merge 3 commits intomicrosoft:masterfrom
ianlini wants to merge 3 commits intomicrosoft:masterfrom
Conversation
Author
|
The |
ianlini
force-pushed
the
fix/use-environment-markers
branch
from
dfbd39e to
7363e3d
Compare
|
|
Author
|
After a few hours of investigation, I found that the environment marker syntax I used may be wrong in the Py35 environment. Luckily, after upgrading |
Author
|
@ganik Could you take a look at this old PR? |
Author
|
@pieths Could you take a look at this old PR? Thanks. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #237.
Please see #237 for more information.