Skip to content

Conversation

@GarmashAlex
Copy link

Replace r with c in comments describing Mz and its evaluation in ppsnark.rs. The code already uses the Fiat–Shamir challenge c to form Mz = Az + cBz + c^2Cz and its evaluation at tau; only the comments were incorrect.

@srinathsetty srinathsetty requested a review from Copilot October 9, 2025 17:48
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR fixes misleading comments in the ppsnark.rs file that incorrectly referenced the variable 'r' when describing the Mz polynomial and its evaluation. The code correctly uses the Fiat-Shamir challenge 'c', but the comments were inconsistent with the implementation.

  • Corrected variable references in comments from 'r' to 'c' for Mz polynomial construction
  • Updated evaluation comments to match the actual code that uses challenge 'c'

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants