CmdPal: Update Extension SDK classes to raise property change notifications only on change #44547
+119
−532
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Adds `SetProperty<T>` method to `BaseObservable` to verify value change before raising property change notification. This prevents unnecessary event emissions from Extension SDK objects when values remain the same. - Replaces direct `OnPropertyChanged` calls with `SetProperty<T>` across relevant objects. - Fixes missing property notifications (e.g. CommandContextItem, ContentPage) - Make Separator observable and allow it to propage notifications about changes to Title and Section properties.
jiripolasek
added
the
Product-Command Palette
zadjii-msft
approved these changes
Jan 8, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of the Pull Request
This PR introduces a new method
bool SetProperty<T>(ref T field, T value, [CallerMemberName] string? propertyName = null)on
BaseObservable.The method updates the backing field only when the new value differs from the current one and raises property change notifications only in that case.
Summary
SetProperty<T>toBaseObservableto guard property change notifications behind an actual value change.PR Checklist
Detailed Description of the Pull Request / Additional comments
Validation Steps Performed