CmdPal: Improve readability and a11y of sections #44556
Merged
+140
−21
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Changes section title color from disabled to secondary text fill. - Moves the separator line slightly lower to align with the section title crossbars. - Changes gallery grid subtitle color from tertiary to secondary text fill.
jiripolasek
added
the
Product-Command Palette
Jay-o-Way
reviewed
Jan 6, 2026
Collaborator
|
Just curious - see a few places where a (literal) value is used, where a style would give the same result. Is there a reason to prefer one over the other? E.G. |
niels9001
reviewed
Jan 6, 2026
Member
|
XAML Styler got you on this one 🙃 |
zadjii-msft
added
the
Needs-Author-Feedback
Collaborator
Author
|
Screenshots updated to match the changes.
if only once...
|
microsoft-github-policy-service
bot
added
Needs-Triage
daverayment
reviewed
Jan 8, 2026
src/modules/cmdpal/Microsoft.CmdPal.UI/Converters/GridItemContainerStyleSelector.cs
Outdated
Show resolved
Hide resolved
niels9001
added
In for .97
and removed
Needs-Triage
niels9001
approved these changes
Jan 8, 2026
niels9001
requested changes
Jan 8, 2026
jiripolasek
removed
the
Needs-Team-Response
niels9001
approved these changes
Jan 8, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of the Pull Request
This PR improves visuals and a11y of sections:
Pictures? Pictures!
PR Checklist
Detailed Description of the Pull Request / Additional comments
Validation Steps Performed