Make the number of tasks on the server and client consistent. #187
Conversation
acured
force-pushed
the
hao/fix_apo_example_tasks_count_inconsistent
branch
from
e27f784 to
812ee13
Compare
|
I think this inconsistency is intentional to let the readers know that the runners could run forever. I agree that the setting max_tasks will make the flow more clear. Please add a comment to let users know that this max_tasks is optional. |
|
We also need to find a way to trigger example workflows. |
|
Please merge from main and close-reopen to trigger ci-apo |
acured
force-pushed
the
hao/fix_apo_example_tasks_count_inconsistent
branch
from
812ee13 to
caefc0e
Compare
|
May I know why you are still working on adding more features to legacy_*.py? |
|
|
||
| # 3. The algorithm waits for clients to process the task | ||
| rollout = await server.poll_completed_rollout(task_id, timeout=30) | ||
| rollout = await server.poll_completed_rollout(task_id, timeout=60) |
There was a problem hiding this comment.
Add timeout and wait for the client to start.
Added |
Easier to trigger this example? |
|
Please merge from main again and see if the tests work now. I think it's a good opportunity to test CI for forked-origin PRs, because I usually open new branches on first-party repo. |
acured
force-pushed
the
hao/fix_apo_example_tasks_count_inconsistent
branch
from
c1be591 to
ffb6d40
Compare
| """This is the APO example written in the legacy client-server style (agent-lightning v0.1). | ||
| New users should refer to the `examples/apo/apo.py` for the modern APO example. | ||
| New users should refer to the `examples/apo/legacy_apo_lunch.py` for the modern APO example. |
| @@ -0,0 +1,87 @@ | |||
| # Copyright (c) Microsoft. All rights reserved. | |||
There was a problem hiding this comment.
I highly doubt that this script will be useful:
- legacy_*.py is no longer maintained and used in future.
- CI used a bash to launch both script and no intermediate glue python script is used.
Also, it seems to me that this script might need a bit more love:
lunch.pylooks like a misspelling.- The module docstring has bad formatting especially the last part. Suggesting letting copilot refine the wording.
| """This is the APO example written in the legacy client-server style (agent-lightning v0.1). | ||
| New users should refer to the `examples/apo/apo.py` for the modern APO example. | ||
| New users should refer to the `examples/apo/legacy_apo_lunch.py` for the modern APO example. |
2 participants
Issue:
Server part exit when all 3 tasks dequeued, but client part will hang there for queue out new task.
127.0.0.1 - - [21/Oct/2025 10:09:18] "POST /traces HTTP/1.1" 200 -
Not sure is it by design? but this example has not been fully executed, may confusing for beginners.
Fixed:
Make the number of tasks on the server and client consistent.