-
Notifications
You must be signed in to change notification settings - Fork 182
chore: upgrade uv requirement to >=0.9.5 and add version constraint #203
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
chore: upgrade uv requirement to >=0.9.5 and add version constraint #203
Conversation
- Add required-version constraint to ensure uv >=0.9.5 is used - Enable extra-build-dependencies for flash-attn (requires uv 0.9.5+) - Update environments to support macOS (darwin) in addition to Linux - Regenerate uv.lock with updated configuration This change ensures that the extra-build-dependencies feature is supported, which is needed for proper flash-attn build configuration. The version constraint prevents compatibility issues when team members use older uv versions. Related to proper dependency management and build reproducibility.
|
@felipeeeantunes please read the following Contributor License Agreement(CLA). If you agree with the CLA, please reply with the following information.
Contributor License AgreementContribution License AgreementThis Contribution License Agreement (“Agreement”) is agreed to by the party signing below (“You”),
|
|
How about cuda dependencies? I'm not thinking very clear about running agent-lightning on macos. I'd rather be cautious about the maintenance effort. |
Summary
This PR upgrades the uv dependency manager requirement to version >=0.9.5 and adds a version constraint to ensure compatibility across the team.
Changes
required-version = ">=0.9.5"to[tool.uv]section inpyproject.tomlextra-build-dependenciesconfiguration forflash-attn(requires uv 0.9.5+)environmentsto support macOS (darwin) in addition to Linuxuv.lockwith updated configurationMotivation
The
extra-build-dependenciesfeature is needed for properflash-attnbuild configuration and is only supported in uv 0.9.5+. Adding a version constraint prevents compatibility issues when team members use older uv versions.Testing
uv syncType of Change
Checklist