-
Notifications
You must be signed in to change notification settings - Fork 111
Adding Support for Relative Paths Go Replace Detector #1254
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
src/Microsoft.ComponentDetection.Detectors/go/GoComponentWithReplaceDetector.cs
Outdated
Show resolved
Hide resolved
src/Microsoft.ComponentDetection.Detectors/go/GoComponentWithReplaceDetector.cs
Outdated
Show resolved
Hide resolved
|
👋 Hi! It looks like you modified some files in the
If none of the above scenarios apply, feel free to ignore this comment 🙂 |
src/Microsoft.ComponentDetection.Detectors/go/GoComponentWithReplaceDetector.cs
Outdated
Show resolved
Hide resolved
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1254 +/- ##
=======================================
+ Coverage 88.9% 89.1% +0.1%
=======================================
Files 359 360 +1
Lines 27643 28076 +433
Branches 1782 1790 +8
=======================================
+ Hits 24600 25027 +427
Misses 2661 2661
- Partials 382 388 +6 ☔ View full report in Codecov by Sentry. |
The Current Go Replace detector does not support replacement paths that are relative paths. It only supports replacement given a path and a version. This was causing errors in Go CLI detection. This new upgraded Go Replacement Detector version supports relative paths, if that path contains a go.mod file. There were also tests as well as telemetry and log statements added for this.