Skip to content

Conversation

@amitla1
Copy link
Contributor

@amitla1 amitla1 commented Sep 30, 2024

The Current Go Replace detector does not support replacement paths that are relative paths. It only supports replacement given a path and a version. This was causing errors in Go CLI detection. This new upgraded Go Replacement Detector version supports relative paths, if that path contains a go.mod file. There were also tests as well as telemetry and log statements added for this.

@amitla1 amitla1 requested a review from a team as a code owner September 30, 2024 19:07
@github-actions
Copy link

github-actions bot commented Sep 30, 2024

👋 Hi! It looks like you modified some files in the Detectors folder.
You may need to bump the detector versions if any of the following scenarios apply:

  • The detector detects more or fewer components than before
  • The detector generates different parent/child graph relationships than before
  • The detector generates different devDependencies values than before

If none of the above scenarios apply, feel free to ignore this comment 🙂

@codecov
Copy link

codecov bot commented Sep 30, 2024

Codecov Report

Attention: Patch coverage is 98.85584% with 5 lines in your changes missing coverage. Please review.

Project coverage is 89.1%. Comparing base (809f458) to head (24bf995).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
...ctors.Tests/GoComponentWithReplaceDetectorTests.cs 98.7% 0 Missing and 5 partials ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##            main   #1254     +/-   ##
=======================================
+ Coverage   88.9%   89.1%   +0.1%     
=======================================
  Files        359     360      +1     
  Lines      27643   28076    +433     
  Branches    1782    1790      +8     
=======================================
+ Hits       24600   25027    +427     
  Misses      2661    2661             
- Partials     382     388      +6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@amitla1 amitla1 merged commit 79ff9ed into main Sep 30, 2024
23 of 26 checks passed
@amitla1 amitla1 deleted the users/avannikumar/goReplaceDetector branch September 30, 2024 22:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants