Skip to content

Conversation

@amitla1
Copy link
Contributor

@amitla1 amitla1 commented Oct 10, 2024

Move Go replace detector from experimental to the regular go detector #1052

@amitla1 amitla1 requested a review from a team as a code owner October 10, 2024 16:32
@amitla1 amitla1 requested a review from FernandoRojo October 10, 2024 16:32
@github-actions
Copy link

github-actions bot commented Oct 10, 2024

👋 Hi! It looks like you modified some files in the Detectors folder.
You may need to bump the detector versions if any of the following scenarios apply:

  • The detector detects more or fewer components than before
  • The detector generates different parent/child graph relationships than before
  • The detector generates different devDependencies values than before

If none of the above scenarios apply, feel free to ignore this comment 🙂

@codecov
Copy link

codecov bot commented Oct 10, 2024

Codecov Report

Attention: Patch coverage is 99.02153% with 5 lines in your changes missing coverage. Please review.

Project coverage is 89.1%. Comparing base (ed4488a) to head (eaadac1).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
...ection.Detectors.Tests/GoComponentDetectorTests.cs 98.9% 0 Missing and 5 partials ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##            main   #1272     +/-   ##
=======================================
- Coverage   89.1%   89.1%   -0.1%     
=======================================
  Files        364     361      -3     
  Lines      28436   27731    -705     
  Branches    1807    1757     -50     
=======================================
- Hits       25364   24718    -646     
+ Misses      2682    2636     -46     
+ Partials     390     377     -13     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@amitla1 amitla1 merged commit 950576a into main Oct 10, 2024
23 of 26 checks passed
@amitla1 amitla1 deleted the users/avannikumar/GoReplaceToProdDetector branch October 10, 2024 17:18
@FernandoRojo FernandoRojo mentioned this pull request Oct 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants