Skip to content

Handle Go Replace Exceptions #1273

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Oct 14, 2024
Merged

Handle Go Replace Exceptions #1273

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
eaf7a6d
handle version exceptions
Oct 11, 2024
65619e6
adding log warning
Oct 14, 2024
6496b3b
Merge branch 'main' into users/avannikumar/handleExceptions
amitla1 Oct 14, 2024
0fb2291
Merge branch 'main' into users/avannikumar/handleExceptions
amitla1 Oct 14, 2024
bd7f5b7
adding module names
Oct 14, 2024
b3809eb
Merge branch 'users/avannikumar/handleExceptions' of https://github.c…
Oct 14, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions src/Microsoft.ComponentDetection.Common/Telemetry/Records/GoReplaceTelemetryRecord.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,4 +7,6 @@
public string GoModPathAndVersion { get; set; }

public string GoModReplacement { get; set; }

public string ExceptionMessage { get; set; }

Check warning on line 11 in src/Microsoft.ComponentDetection.Common/Telemetry/Records/GoReplaceTelemetryRecord.cs

View check run for this annotation

Codecov / codecov/patch

src/Microsoft.ComponentDetection.Common/Telemetry/Records/GoReplaceTelemetryRecord.cs#L11 

Added line #L11 was not covered by tests
}
13 changes: 11 additions & 2 deletions src/Microsoft.ComponentDetection.Detectors/go/GoComponentDetector.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -477,10 +477,19 @@
if (dependency.Replace?.Path != null && dependency.Replace.Version != null)
{
var dependencyReplacementName = $"{dependency.Replace.Path} {dependency.Replace.Version}";
goComponent = new GoComponent(dependency.Replace.Path, dependency.Replace.Version);
this.Logger.LogInformation("go Module {GoModule} being replaced with module {GoModuleReplacement}", dependencyName, dependencyReplacementName);
record.GoModPathAndVersion = dependencyName;
record.GoModReplacement = dependencyReplacementName;
try
{
goComponent = new GoComponent(dependency.Replace.Path, dependency.Replace.Version);
this.Logger.LogInformation("go Module {GoModule} being replaced with module {GoModuleReplacement}", dependencyName, dependencyReplacementName);
}
catch (Exception ex)
{
record.ExceptionMessage = ex.Message;
this.Logger.LogWarning("tried to use replace module {GoModuleReplacement} but got this error {ErrorMessage} using original module {GoModule} instead", dependencyReplacementName, ex.Message, dependencyName);
goComponent = new GoComponent(dependency.Path, dependency.Version);
}

Check warning on line 492 in src/Microsoft.ComponentDetection.Detectors/go/GoComponentDetector.cs

View check run for this annotation

Codecov / codecov/patch

src/Microsoft.ComponentDetection.Detectors/go/GoComponentDetector.cs#L487-L492 

Added lines #L487 - L492 were not covered by tests
}
else
{
Expand Down
Loading