Skip to content

Conversation

@sandernaus
Copy link

πŸ› οΈ Description

Fixes the logic to generate the scopes in the settings.json.

  • The object created for $newScopes is differently structure, compared to $json.scopes, resulting in not just merging them using the +
  • The validation for scopes is wrongly set, as now the length of the dictionary is checked (which is 1), and not the length of the string value for the actual scope key, causing all scopes to be discarded

Fixes #1880

πŸ“‹ Checklist

πŸ”¬ How did you test this change?

  • 🀏 Lint tests
  • 🀞 PS -WhatIf / az validate
  • πŸ‘ Manually deployed + verified
  • πŸ’ͺ Unit tests
  • πŸ™Œ Integration tests

πŸ™‹β€β™€οΈ Do any of the following that apply?

  • 🚨 This is a breaking change.
  • 🀏 The change is less than 20 lines of code.

πŸ“‘ Did you update docs/changelog.md?

  • βœ… Updated changelog (required for dev PRs)
  • ➑️ Will add log in a future PR (feature branch PRs only)
  • ❎ Log not needed (small/internal change)

πŸ“– Did you update documentation?

  • βœ… Public docs in docs (required for dev)
  • βœ… Internal dev docs in src (required for dev)
  • ➑️ Will add docs in a future PR (feature branch PRs only)
  • ❎ Docs not needed (small/internal change)

@sandernaus
Copy link
Author

@microsoft-github-policy-service agree company="Rabobank"

@RolandKrummenacher RolandKrummenacher added this to the v13 milestone Dec 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Micro PR πŸ”¬ Very small PR that should be especially easy for newcomers Needs: Review πŸ‘€ PR that is ready to be reviewed Tool: FinOps hubs Data pipeline solution

Projects

None yet

Development

Successfully merging this pull request may close these issues.

scopes in settings.json is not properly populated

7 participants