Add .NET NuGet package for NetRemote gRPC API bindings #353
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type
Side Effects
Goals
Add support for packaging and distributing the NetRemote .proto APIs as a .NET NuGet package (
Microsoft.Net.Remote.Client). This enables .NET consumers to easily reference the NetRemote gRPC services without manually compiling proto files.Additionally, reorganize the .NET project structure to improve clarity and maintainability:
/api/dotnet/Technical Details
NuGet Package (
api/dotnet/):netstandard2.1for broad compatibility (.NET Core 3.0+, .NET 5+)build.sh,build.ps1)cmake --build . --target nuget-packProject Structure Cleanup:
/packaging/nuget/to/api/dotnet/(co-located with/api/protos/and/api/protocol/)/src/common/dotnet/NetRemoteClient/(replaced by/api/dotnet/)/src/common/dotnet/NetRemoteService/(unimplemented stub)/tests/integration/dotnet/and renamed to reflect their nature as integration testsCI/CD Integration:
.github/workflows/dotnet-tests.ymlworkflow for .NET builds and testscicd.ymlTest Results
Verified .NET integration tests pass:
dotnet testpasses on Linux (net8.0)dotnet buildsucceeds for NuGet packagedotnet packcreates valid .nupkgReviewer Focus
Please review:
/api/dotnet/- especially the proto file references and NuGet packaging configurationFuture Work
Checklist
allcompiles cleanly.