Draft
Conversation
- Add 'submodules: recursive' to checkout action in build.yml so the vcpkg submodule is properly initialized before bootstrap - Add autoconf-archive to apt-get install for libxcrypt build - Remove apt-get upgrade to avoid container package conflicts - Add .actrc and .secrets.example for local act testing
The vcpkg.cmake script already initializes the vcpkg submodule during CMake configure via 'git submodule update --init --recursive'. The Bootstrap vcpkg step was failing because it ran before CMake had a chance to initialize the submodule. Also reverts the unnecessary 'submodules: recursive' checkout option.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Type
Side Effects
Goals
Technical Details
Test Results
Reviewer Focus
Future Work
Checklist
allcompiles cleanly.