Skip to content

Conversation

@pavelfeldman
Copy link
Member

Fixes #38551

@github-actions

This comment has been minimized.

@pavelfeldman
Copy link
Member Author

@cpAdm do you want to review this one? We used to pass absolute file path into traceURL and I replaced it with the uri that contains path + timestamp.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

Copy link
Contributor

@cpAdm cpAdm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can confirm that these changes fixes the related issue. But whilst add it, I think we should try to solve #38364 as well

return;
}

const traceLocation = [
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fetching this resource always fails

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What do you mean? No live traces tests would pass if this failed.

@github-actions
Copy link
Contributor

Test results for "tests 1"

2 failed
❌ [playwright-test] › web-server.spec.ts:25 › should create a server @windows-latest-node20-2
❌ [playwright-test] › web-server.spec.ts:555 › should create multiple servers @windows-latest-node20-2

1 flaky ⚠️ [firefox-library] › library/inspector/cli-codegen-1.spec.ts:1083 › cli codegen › should not throw csp directive violation errors `@firefox-ubuntu-22.04-node20`

34366 passed, 692 skipped


Merge workflow run.

@github-actions
Copy link
Contributor

Test results for "MCP"

5 failed
❌ [chromium] › mcp/screenshot.spec.ts:222 › browser_take_screenshot (filename: "output.png") @mcp-macos-15
❌ [chromium] › mcp/video.spec.ts:21 › should work with --save-video (isolated) @mcp-macos-15
❌ [chromium] › mcp/video.spec.ts:63 › should work with recordVideo (isolated) @mcp-macos-15
❌ [chromium] › mcp/video.spec.ts:21 › should work with --save-video (persistent) @mcp-macos-15
❌ [chromium] › mcp/video.spec.ts:63 › should work with recordVideo (persistent) @mcp-macos-15

2709 passed, 116 skipped


Merge workflow run.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Regression]: UI does not update actions (and more) for a re-run

3 participants