-
Notifications
You must be signed in to change notification settings - Fork 4.9k
fix(html): propagate auth tokens #38634
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
I tried my best to make this work, but there's asset links in too many places that we can't propagate the SAS token to. JS imports and top-level CSS imports can be hacked around with dynamic scripts and import maps. But there's also font files referenced from CSS, and I just don't see any way for making that work. |
Test results for "MCP"4 failed 2723 passed, 116 skipped Merge workflow run. |
Test results for "tests 1"75 failed 3 flaky34325 passed, 689 skipped Merge workflow run. |
Draft for #38622, propagating auth tokens in search params. Adds a post-build patchup that replaces
<script>and<link>tags into script that creates these tags dynamically, but with the search param. Here's how it looks: