Migrate PowerBI embedding components to Angular standalone components #83
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Author
|
@microsoft-github-policy-service agree |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request refactors the Angular PowerBI embedding components to leverage Angular’s standalone component feature, making NgModule usage optional. This simplifies both module management and test setup.
Key changes:
Standalone components: All PowerBI embedding components are now marked with
standalone: true,allowing them to be imported and used directly without requiring a module.Module updates: powerbi-embed.module.ts was updated to use imports instead of declarations, reflecting the migration. The redundant empty imports array was removed.
Simplified testing: Removed unnecessary TestBed.configureTestingModule calls from all spec files, since standalone components can be instantiated directly in tests.