Skip to content

Conversation

@vmoroz
Copy link
Member

@vmoroz vmoroz commented Nov 3, 2025

Description

Type of Change

  • New feature (non-breaking change which adds functionality)

Why

We should switch to a new version of hermes-windows and node-api-jsi to unblock our progress with adoption of new Hermes debugger. This version of Hermes contains all latest changes to Node-API code that we did to prepare PR to upstream the Node-API implementation to facebook/hermes repo (facebook/hermes#1377).
The hermes-windows 0.0.0-2511.3001-9e4cf518 release is corresponding to the merge of the modern inspector support to the hermes-windows code: PR: microsoft/hermes-windows#257, commit: microsoft/hermes-windows@9e4cf51

What

  • The Hermes version is updated in the vnext/PropertySheets/JSEngine.props file to 0.0.0-2511.3001-9e4cf518.
  • Ran vnext\Scripts\NuGetRestoreForceEvaluateAllSolutions.ps1 script to update all packages.lock.json files.
  • Since the latest version of hermes-windows uses two new Node-API files node_api.h and node_api_types.h we have to intgrate the node-api-jsi PR that updates Node-API files: Update Node-API files node-api-jsi#15.
  • The related node-api-jsi commit hash is updated to 21b47f08b762b21b1d4d970940ab23f59f43249c in vnext/Microsoft.ReactNative.Cxx/Microsoft.ReactNative.Cxx.vcxitems and vnext/Directory.Build.props files.
  • The new Node-API files node_api.h and node_api_types.h are added to vnext/Scripts/Tfs/Layout-MSRN-Headers.ps1 and vnext/Microsoft.ReactNative.Cxx/Microsoft.ReactNative.Cxx.vcxitems files.

Testing

The playground-composition app seems to be running OK.

Changelog

Should this change be included in the release notes: yes

Use Hermes version 0.0.0-2511.3001-9e4cf518

Microsoft Reviewers: Open in CodeFlow

@iamAbhi-916 iamAbhi-916 merged commit 01e9577 into microsoft:main Nov 6, 2025
58 checks passed
@vmoroz vmoroz deleted the PR/use_hermes-windows_0.0.0-2511.3001-9e4cf518 branch November 6, 2025 16:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants