Use hermes-windows version 0.0.0-2511.3001-9e4cf518 #15303
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Type of Change
Why
We should switch to a new version of
hermes-windowsandnode-api-jsito unblock our progress with adoption of new Hermes debugger. This version of Hermes contains all latest changes to Node-API code that we did to prepare PR to upstream the Node-API implementation tofacebook/hermesrepo (facebook/hermes#1377).The hermes-windows
0.0.0-2511.3001-9e4cf518release is corresponding to the merge of the modern inspector support to the hermes-windows code: PR: microsoft/hermes-windows#257, commit: microsoft/hermes-windows@9e4cf51What
vnext/PropertySheets/JSEngine.propsfile to0.0.0-2511.3001-9e4cf518.vnext\Scripts\NuGetRestoreForceEvaluateAllSolutions.ps1script to update allpackages.lock.jsonfiles.hermes-windowsuses two new Node-API filesnode_api.handnode_api_types.hwe have to intgrate thenode-api-jsiPR that updates Node-API files: Update Node-API files node-api-jsi#15.node-api-jsicommit hash is updated to21b47f08b762b21b1d4d970940ab23f59f43249cinvnext/Microsoft.ReactNative.Cxx/Microsoft.ReactNative.Cxx.vcxitemsandvnext/Directory.Build.propsfiles.node_api.handnode_api_types.hare added tovnext/Scripts/Tfs/Layout-MSRN-Headers.ps1andvnext/Microsoft.ReactNative.Cxx/Microsoft.ReactNative.Cxx.vcxitemsfiles.Testing
The playground-composition app seems to be running OK.
Changelog
Should this change be included in the release notes: yes
Use Hermes version 0.0.0-2511.3001-9e4cf518
Microsoft Reviewers: Open in CodeFlow