-
Notifications
You must be signed in to change notification settings - Fork 6
HTTPPlugin : Add a builder option to provide custom server (enables providing options like ssl etc) #185
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR adds support for custom server configuration in the HTTPPlugin by introducing a server_factory parameter. This enables users to provide their own pre-configured uvicorn server with custom options like SSL certificates, custom logging, or other server-level configurations.
Key Changes:
- Added optional
server_factoryparameter to HTTPPlugin constructor - Modified startup logic to use custom server when provided, with port conflict detection
- Added documentation for the new parameter
Co-authored-by: Copilot <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Talked offline. This makes sense to me. Add the code comment and 🚢
b55597b to
5e48bf7
Compare
Tested with code like (check running on and activities received on port 8000 )