Skip to content

Conversation

@lilyydu
Copy link
Collaborator

@lilyydu lilyydu commented Jun 13, 2025

setup API package to avoid merge conflicts

Copilot AI review requested due to automatic review settings June 13, 2025 18:25
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR sets up a new api package alongside the existing cards package and adjusts project workspace settings to include it.

  • Added api as a workspace member and dependency in the root pyproject.toml.
  • Updated cards package metadata, dependencies, and project URLs.
  • Introduced a scaffolded api package with license headers and its own pyproject.toml.

Reviewed Changes

Copilot reviewed 8 out of 8 changed files in this pull request and generated no comments.

Show a summary per file
File Description
pyproject.toml Added "api" dependency and workspace source entry
packages/cards/src/cards/init.py Replaced hello() stub with license header
packages/cards/pyproject.toml Modified version, repository URL, keywords, license, authors, dependencies, and added dev group
packages/api/src/api/init.py Added license header
packages/api/pyproject.toml Introduced initial project configuration for api package
Comments suppressed due to low confidence (5)

packages/cards/pyproject.toml:14

  • Coverage is typically a dev tool rather than a runtime dependency; consider moving it into the [dependency-groups.dev] section.
+    "coverage>=7.8.0",

packages/cards/pyproject.toml:17

  • Ruff is a linting tool and shouldn’t be listed as a runtime dependency; move it to the dev dependency group.
+    "ruff>=0.11.5",

packages/api/src/api/init.py:1

  • [nitpick] The module only contains a license header; add a brief docstring explaining this package’s purpose or initial API.
+"""

packages/api/src/api/init.py:1

  • No tests are present for the new api package; consider adding unit tests under a tests/ directory to validate its behavior.
+"""

packages/cards/pyproject.toml:3

  • The version was downgraded from "0.1.0" to "0.0.0", which conflicts with semantic versioning; consider bumping to a new patch or minor version instead of resetting to "0.0.0".
+version = "0.0.0"

@lilyydu lilyydu closed this Jun 13, 2025
@lilyydu lilyydu deleted the lilyydu/api-module-setup branch August 20, 2025 21:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants