[Fix] streaming: do not reset timeout for each chunk emit #378
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MehakBindra
changed the title
heyitsaamir
approved these changes
Oct 17, 2025
Collaborator
heyitsaamir
left a comment
heyitsaamir
left a comment
There was a problem hiding this comment.
Makes sense to me. Talked to Mehak offline about this too. @aacebo can you take a look too?
corinagum
approved these changes
Oct 23, 2025
Collaborator
|
@MehakBindra can you add some tests around this area? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue : #374
Main change::
- flush immediately if no timeout pending,
- else push to queue and wait.
Screen.Recording.2025-10-16.140937.mp4
Devtools: Streaming always starts before the full response is received (check with logs, see attached video).
Teams: Even though the first chunk is emitted immediately, (sometimes) by the time the stream starts on Teams, the full response is ready. In the second msg, we can see the stream starts a little bit before the full response is printed.