Skip to content

Conversation

@cwize1
Copy link
Contributor

@cwize1 cwize1 commented Aug 13, 2025

πŸ” Description

Update the rust version in the docs from 1.72.0 to 1.88.0.

πŸ€” Rationale

Ensure the docs are accurate.

πŸ“ Checks

πŸ“Œ Follow-ups

None

πŸ—’οΈ Notes

None

Update the rust version in the docs from 1.72.0 to 1.88.0.
@cwize1 cwize1 requested a review from a team as a code owner August 13, 2025 21:09
- The required version of Rust is 1.72.0. To install this version, run `rustup
install 1.72.0`. To set this as your default version, also run `rustup default
1.72.0`.
install 1.88.0`. To set this as your default version, also run `rustup default
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: the minimum required version is still 1.72, but the latest supported by trident (which alsi happens to be the latest available right now) is 1.88.

To install this version ...

Just change to something like "to update the latest supported version", or maybe remove the version altogether since we'd be changing that every so often.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the error I get with v1.72.0:

error: failed to download `scroll v0.13.0`

Caused by:
  unable to get packages from source

Caused by:
  failed to download replaced source registry `crates-io`

Caused by:
  failed to parse manifest at `/home/chris/.cargo/registry/src/index.crates.io-6f17d22bba15001f/scroll-0.13.0/Cargo.toml`

Caused by:
  failed to parse the `edition` key

Caused by:
  this version of Cargo is older than the `2024` edition, and only supports `2015`, `2018`, and `2021` editions.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm, in that case should we bump package.rust-version in Cargo.toml too @fintelia ?

fintelia
fintelia previously approved these changes Aug 13, 2025
```

- Install Rust and Cargo: `curl https://sh.rustup.rs -sSf | sh`.
- The required version of Rust is 1.72.0. To install this version, run `rustup
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Err, shouldn't we update this line too

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants