-
Notifications
You must be signed in to change notification settings - Fork 5
Update rust version in docs. #107
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Update the rust version in the docs from 1.72.0 to 1.88.0.
| - The required version of Rust is 1.72.0. To install this version, run `rustup | ||
| install 1.72.0`. To set this as your default version, also run `rustup default | ||
| 1.72.0`. | ||
| install 1.88.0`. To set this as your default version, also run `rustup default |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: the minimum required version is still 1.72, but the latest supported by trident (which alsi happens to be the latest available right now) is 1.88.
To install this version ...
Just change to something like "to update the latest supported version", or maybe remove the version altogether since we'd be changing that every so often.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is the error I get with v1.72.0:
error: failed to download `scroll v0.13.0`
Caused by:
unable to get packages from source
Caused by:
failed to download replaced source registry `crates-io`
Caused by:
failed to parse manifest at `/home/chris/.cargo/registry/src/index.crates.io-6f17d22bba15001f/scroll-0.13.0/Cargo.toml`
Caused by:
failed to parse the `edition` key
Caused by:
this version of Cargo is older than the `2024` edition, and only supports `2015`, `2018`, and `2021` editions.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmm, in that case should we bump package.rust-version in Cargo.toml too @fintelia ?
dev-docs/prerequisites.md
Outdated
| ``` | ||
|
|
||
| - Install Rust and Cargo: `curl https://sh.rustup.rs -sSf | sh`. | ||
| - The required version of Rust is 1.72.0. To install this version, run `rustup |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Err, shouldn't we update this line too
π Description
Update the rust version in the docs from 1.72.0 to 1.88.0.
π€ Rationale
Ensure the docs are accurate.
π Checks
π Follow-ups
None
ποΈ Notes
None