Ignore Enter for replace while composing. Fix #257776 #273452
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes an issue where pressing Enter during IME composition in the find/replace widget would trigger the replace action prematurely. The fix adds an isComposing precondition to prevent Enter from executing the replace command while text is being composed.
Key Changes:
- Added
isComposingprecondition to the replace command's keyboard binding expression to prevent premature activation during IME composition.
Tyriar
requested changes
Nov 10, 2025
| kbOpts: { | ||
| weight: KeybindingWeight.EditorContrib + 5, | ||
| kbExpr: ContextKeyExpr.and(EditorContextKeys.focus, CONTEXT_REPLACE_INPUT_FOCUSED), | ||
| kbExpr: ContextKeyExpr.and(EditorContextKeys.focus, CONTEXT_REPLACE_INPUT_FOCUSED, EditorContextKeys.isComposing.negate()), |
Member
There was a problem hiding this comment.
This context key is never used so it doesn't do anything? Am I missing someting? @osortega
Contributor
There was a problem hiding this comment.
Looks like we are creating it here
vscode/src/vs/workbench/services/keybinding/browser/keybindingService.ts
Lines 202 to 203 in 541da45
But it was never added to EditorContextKeys
@tamuratak could you make sure we use is there?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ignore Enter for replace while composing (add isComposing precondition). Fix #257776.
Similar to #174829