fix: suppress linker warnings exposed by nightly rustc change#279
Merged
wmmc88 merged 1 commit intomicrosoft:mainfrom Jan 28, 2025
Merged
fix: suppress linker warnings exposed by nightly rustc change#279wmmc88 merged 1 commit intomicrosoft:mainfrom
wmmc88 merged 1 commit intomicrosoft:mainfrom
Conversation
leon-xd
approved these changes
Jan 28, 2025
ayodejiige
approved these changes
Jan 28, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request includes changes to the
crates/wdk-build/src/lib.rsfile to address linker warnings when building Windows drivers. The most important changes involve adding linker arguments to ignore specific warnings that are safe to ignore.These warnings were exposed by a change in nightly toolchain. Even though the change has been since downgraded to allow by default, we should still explicitly ignore these linker warnings since they are safe to ignore.
Linker warning suppression:
LNK4257: object file was not compiled for kernel mode; the image might not runfor both Kernel Mode Driver Framework (KMDF) and Windows Driver Model (WDM) configurations. (crates/wdk-build/src/lib.rs, [1] [2]LNK4216: Exported entry point DriverEntryfor the WDM configuration. (crates/wdk-build/src/lib.rs, crates/wdk-build/src/lib.rsR716-R724)