-
Notifications
You must be signed in to change notification settings - Fork 122
Data - 35015 - Global Scope Label Count #758
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This pull request adds a new security assessment test (Test-Assessment.35015) to check if globally-scoped sensitivity label policies exceed the Microsoft-recommended limit of 25 labels. The test evaluates whether organizations are publishing too many labels globally, which can cause user confusion and misclassification.
Key changes:
- Implements test logic to identify globally-scoped label policies and count unique published labels
- Generates detailed reports showing global label policies and their label counts
- Provides remediation guidance for reducing globally-published labels
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| src/powershell/tests/Test-Assessment.35015.ps1 | New PowerShell test function that queries label policies, identifies globally-scoped policies, counts unique labels, and generates assessment results |
| src/powershell/tests/Test-Assessment.35015.md | Documentation providing context, best practices, and remediation steps for managing global scope label counts |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <[email protected]>
|
@copilot - please review again |
|
@Manoj-Kesana I've opened a new pull request, #762, to work on those changes. Once the pull request is ready, I'll request review from you. |
Co-authored-by: Manoj-Kesana <[email protected]>
Fix incomplete global policy scope detection in Test-Assessment.35015
|
@alexandair - requesting your review as we have received comments from Sagar to proceed on this one with current logic |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
@Manoj-Kesana You didn't address Copilot's feedback. |
Co-authored-by: Copilot <[email protected]>
Co-authored-by: Copilot <[email protected]>
Co-authored-by: Copilot <[email protected]>
Global Scope Label Count