Wrong prep #62
Open
Wrong prep #62
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 9 commits
June 18, 2021 13:31
with countries
src/reynir_correct/pattern.py
Outdated
| given a set of variants""" | ||
|
|
||
| # Get rid of argument variants in verbs: | ||
| variants = list([x for x in variants if not x.isdigit()]) |
Member
There was a problem hiding this comment.
Either list() or [] are superfluous, only one of the two is required
Member
There was a problem hiding this comment.
...in fact the isdigit() filter is done twice. This could be:
realvars = [x for x in variants if not x.isdigit() and x not in SKIPVARS]
entirely dropping the for loop.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Handling for wrong prepositions.