cherry-pick UPSTREAM: docker/distribution: 3296: allow pointing to an AWS config … #30
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
kaovilai
commented
Jul 11, 2023
kaovilai
commented
- Revert "remove v3 from name for discovery"
- UPSTREAM: docker/distribution: 3296: allow pointing to an AWS config file as a parameter for the s3 driver
This reverts commit aa6c4b2.
…file as a parameter for the s3 driver Recognize a new parameter when setting up the AWS client so that a generic AWS config file can be used instead of having to specify AWS access and secret keys. This should allow someone to use different authentication methods beyond just access key, secret key (and optionally session token). Using the current supported auth methods a valid file would look like: ``` [default] aws_access_key_id = AKMYAWSACCCESSKEYID aws_secret_access_key = myawssecretaccesskey ``` But you can also specify alternative auth methods: ``` [default] role_arn = arn:aws:iam:ACCOUNT_NUM:role/ROLE_NAME web_identity_token_file = /path/to/token ``` Signed-off-by: Tiger Kaovilai <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.