-
Notifications
You must be signed in to change notification settings - Fork 8
MTA-5174 Add Custom Rules in More Languages #272
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
| category: potential | ||
| effort: 3 | ||
| when: | ||
| builtin.file: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wonder if we can use a different rule here, as this is using the builtin provider rather than the go provider.
go.referenced:
pattern: "v1beta1.CustomResourceDefinition"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you! I modified the rule.
| - ruleID: test-tsx-support-00000 | ||
| description: Found React import in .tsx file | ||
| when: | ||
| builtin.filecontent: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same as above comment. This can be added to the following rule:
- nodejs.referenced:
pattern: "React"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you! Modified the rule here too.
Signed-off-by: Prabha Kylasamiyer Sundara Rajan <[email protected]>
b8bae8d to
572d9cb
Compare
JIRA
MTA-5174 [DOC] Add custom ruleset for other languages
Version
Preview