Skip to content

Conversation

@Pkylas007
Copy link
Collaborator

@Pkylas007 Pkylas007 commented Dec 3, 2025

@Pkylas007 Pkylas007 requested review from jmle and sshveta December 3, 2025 06:47
@Pkylas007 Pkylas007 requested a review from eemcmullan December 8, 2025 03:09
category: potential
effort: 3
when:
builtin.file:

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder if we can use a different rule here, as this is using the builtin provider rather than the go provider.

    go.referenced:
        pattern: "v1beta1.CustomResourceDefinition"

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! I modified the rule.

- ruleID: test-tsx-support-00000
description: Found React import in .tsx file
when:
builtin.filecontent:

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same as above comment. This can be added to the following rule:

    - nodejs.referenced:
        pattern: "React"

Copy link
Collaborator Author

@Pkylas007 Pkylas007 Dec 12, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! Modified the rule here too.

@Pkylas007 Pkylas007 requested a review from eemcmullan December 12, 2025 05:02
Signed-off-by: Prabha Kylasamiyer Sundara Rajan <[email protected]>
@Pkylas007 Pkylas007 force-pushed the mta-5174-add-custom-rules branch from b8bae8d to 572d9cb Compare December 12, 2025 09:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants